Refactor remaining files in parser/utils #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #761 +/- ##
==========================================
- Coverage 82.62% 82.59% -0.03%
==========================================
Files 141 141
Lines 11496 11495 -1
Branches 2126 2126
==========================================
- Hits 9498 9494 -4
- Misses 1667 1670 +3
Partials 331 331 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💫 Changelog
⭐ Improved typesafety in the remaining TS files located in
parser/utils.⭐ Changed
vartoletandconstas applicable.⭐ Added strict equality check
⭐ If the name of identifiers of key and value are the same, do not pass the value identifier explicitly. E.g: Instead of using
atoms.push({x:x,y:y})simply useatoms.push({x,y})